Fix dev packager global reference #9814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
When running parcel without scope hoisting,
global
references are not passed through correctly in theDevPackager
module. This results in runtime errors when any code directly usesglobal.
without any checks of its existence sincevar global = arguments[3]
is always undefined. These changes amend the pass through of the global object, so thatarguments[3]
exists under a privately namespaced variable to prevent collisions with other constants named global.🚨 Test instructions
yarn test:integration