-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to napi-rs v2 #120
Update to napi-rs v2 #120
Conversation
This seems to be causing segfaults occasionally in my testing, and I don't know why... Might be a bug in napi-rs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much cleaner 🤯. If the segmentation fault is not an issue with this version it looks good to me code-wise.
Sorry for the late review, this PR got buried in gh notifications
Seg fault should be fixed in latest napi now |
This updates the node bindings to use napi-rs v2, with the new derive macro which really simplifies generating classes and methods a lot. Also bumps Rust to the 2021 edition.