Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build module in a folder with spaces #73

Closed
bpasero opened this issue Oct 15, 2021 · 1 comment · Fixed by #74
Closed

Cannot build module in a folder with spaces #73

bpasero opened this issue Oct 15, 2021 · 1 comment · Fixed by #74

Comments

@bpasero
Copy link
Contributor

bpasero commented Oct 15, 2021

Steps:

  • clone the project to a folder with spaces in the name
  • try to yarn

It fails:

CC(target) Release/obj.target/nothing/node_modules/node-addon-api/nothing.o
  LIBTOOL-STATIC Release/nothing.a
warning: /Library/Developer/CommandLineTools/usr/bin/libtool: archive library: Release/nothing.a the table of contents is empty (no object file members in the library define global symbols)
  CXX(target) Release/obj.target/watcher/src/binding.o
clang: error: no such file or directory: 'folder/node_modules/node-addon-api'
make: *** [Release/obj.target/watcher/src/binding.o] Error 1
@bpasero
Copy link
Contributor Author

bpasero commented Oct 15, 2021

Thanks to @deepak1556 for the actual fix (refs: microsoft/vscode#135100 (comment))

DeMoorJasper pushed a commit that referenced this issue Oct 16, 2021
* Cannot build module in a folder with spaces (fix #73)

* fix windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant