New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle errors in callback #80

Merged

devongovett merged 1 commit into master from fix/uncaught-exception-callback

Oct 30, 2021

Member

DeMoorJasper commented Oct 29, 2021 •

edited

This ensures we handle errors in the callbacks, instead of segfault this throws it as an uncaught exception.

Not sure if this is the way to go, or if we should log this to cerr instead or even ignore it completely.


          throw uncaught exceptions as uncaught exception instead of segfaulting

f496db4

DeMoorJasper requested a review from devongovett

October 29, 2021 18:26

height bot commented Oct 29, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

devongovett approved these changes

View reviewed changes

devongovett merged commit cb4493c into master

devongovett deleted the fix/uncaught-exception-callback branch

October 30, 2021 02:05

devongovett mentioned this pull request

Segfaults when throwing an error in the callback #78

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment