Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add card meta tags #5

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Add card meta tags #5

merged 1 commit into from
Dec 5, 2017

Conversation

henrycatalinismith
Copy link

Hi there, love the project ❤️

Just noticed there's no meta tags on the website though and figured this was something small but important I could maybe help a little with. I've run the code in this PR through Twitter's card testing tool and here's how it came out.

screen shot 2017-12-05 at 20 02 33

It's possible to do more than this with these tags but I thought I'd try the quick fixes first! 😇

@henrycatalinismith
Copy link
Author

Hmmm thinking about it more... maybe this looks a lot better with the shorter copy from the front page of the site...

screen shot 2017-12-05 at 20 09 12

What d'you reckon?

@devongovett
Copy link
Member

I like the second option 👍 Thanks!

@henrycatalinismith
Copy link
Author

No probs, updated the commit with those words!

@devongovett devongovett merged commit deabe5d into parcel-bundler:master Dec 5, 2017
@devongovett
Copy link
Member

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants