Regression: Environment modules are not installed by install-dependencies

[Saremox]

bfe3a27 introduced a regression. If you use install-dependencies the script does not install the needed spack package Environment modules.

. ./scripts/environment.sh
==> Error: Spec 'environment-modules' matches no installed packages.
/home/michael/julea/dependencies/share/spack/setup-env.sh: line 145: module: command not found
/home/michael/julea/dependencies/share/spack/setup-env.sh: line 145: module: command not found
/home/michael/julea/dependencies/share/spack/setup-env.sh: line 145: module: command not found
/home/michael/julea/dependencies/share/spack/setup-env.sh: line 145: module: command not found
/home/michael/julea/dependencies/share/spack/setup-env.sh: line 145: module: command not found
/home/michael/julea/dependencies/share/spack/setup-env.sh: line 145: module: command not found
/home/michael/julea/dependencies/share/spack/setup-env.sh: line 145: module: command not found

Steps to reproduce with a docker image

docker run -i ubuntu:xenial bash
apt-get -y update
apt-get -y install software-properties-common python-software-properties build-essential python curl git 
add-apt-repository ppa:jonathonf/gcc
apt-get -y update
apt-get -y install gcc-7 g++-7 
useradd -m michael
su michael
cd ~
git clone https://github.com/wr-hamburg/julea.git
cd julea
./scripts/install-dependencies.sh
./waf.sh configure --debug --sanitize
./waf.sh build
. ./scripts/environment.sh

[Saremox]

Patch to fix the above mentioned regression. Don't know if thats the the new intended way to define Dependencies:

Date: Fri, 7 Sep 2018 18:03:55 +0200
Subject: [PATCH] Fix spack regression

---
 scripts/spack | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/spack b/scripts/spack
index dabe838..c3fb7d4 100644
--- a/scripts/spack
+++ b/scripts/spack
@@ -105,6 +105,9 @@ spack_get_dependencies ()
 
 	dependencies=''
 
+	# Required for Spack itself
+	dependencies="${dependencies} environment-modules"
+
 	# Required for Waf
 	dependencies="${dependencies} pkgconfig"
 
-- 
2.18.0

[michaelkuhn]

Good catch, thanks!