Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of execute functions #39

Closed
ezickler opened this issue Jul 24, 2019 · 1 comment
Closed

Improve readability of execute functions #39

ezickler opened this issue Jul 24, 2019 · 1 comment
Assignees

Comments

@ezickler
Copy link
Contributor

This is just an idea to improve the readability and thus make it easy for new devs to understand the code.

I noticed that in jkv, jobject and jdistributed-object many but not all exec function have a repeated pattern of checking for local backend existence. It is check inconsistently either via != or ==. Doing this in a consistent way would make it easier to read and understand.

Here is an example:
https://github.com/wr-hamburg/julea/blob/879b745059b41abd76fa816bd9458d49dcd89441/lib/object/jobject.c#L188-L228

@michaelkuhn michaelkuhn self-assigned this Dec 18, 2020
@michaelkuhn
Copy link
Member

The checks should be more consistent in b14074e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants