Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "kb/api-version-3/" prefix from relative links #56

Merged
merged 1 commit into from
Sep 1, 2015

Conversation

RyanLB
Copy link
Contributor

@RyanLB RyanLB commented Sep 1, 2015

Fixes #55. Removes the "kb/api-version-3" prefix from relative links any time it appears.

@humeansacrifice
Copy link
Contributor

@et this looks good to me. Can we merge?

@bmsteele
Copy link
Contributor

bmsteele commented Sep 1, 2015

i like #YOLO

bmsteele added a commit that referenced this pull request Sep 1, 2015
Remove the "kb/api-version-3/" prefix from relative links
@bmsteele bmsteele merged commit d1bbe1c into pardot:master Sep 1, 2015
@et
Copy link
Contributor

et commented Sep 1, 2015

@humeansacrifice says she was having problems with these links locally...we should revert this unless someone can confirm this works properly

@bmsteele
Copy link
Contributor

bmsteele commented Sep 1, 2015

@et yep reverted for now. When you test locally, the change is good if you manually append a trailing slash (so locally kb/api-version-3/object-field-references doesn't work but kb/api-version-3/object-field-references/ does —— but this should be handled nicely with a 301 redirect on our web server anyway).

All that being said... I'm missing something here. Not sure why these links stopped working in the first place. I had a dated local copy and didn't really see any differences.

@et
Copy link
Contributor

et commented Sep 1, 2015

I actually just tried this locally and it seemed to work fine. Super good fix to handle those busted links. @humeansacrifice can you provide some details as to what your issue was?

@humeansacrifice
Copy link
Contributor

@et I get 404s for the links that were previously broken.

@et
Copy link
Contributor

et commented Sep 1, 2015

Thanks @RyanLB! I believe we had some people on different versions of mkdocs but those are fixed.
Your changes are now live.
Much ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to knowledge base are broken
4 participants