Handle additional net-related errors #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dot::NetError so implementors don't need to catch multiple types of exceptions
…causes the XML parser to error. I believe this happens when the Pardot webserver (not the Pardot app) handles load or connection issues, not knowing the client expects XML
znbailey
added a commit
that referenced
this pull request
Jul 28, 2014
Handle additional net-related errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running thousands of requests every day using this gem, and there's a handful of net-related exceptions that the gem should catch and wrap in Pardot::NetError so I don't need to catch additional exception types