Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX bokeh plot in admin dashboard (#461) #477

Merged
merged 1 commit into from Nov 26, 2020

Conversation

rth
Copy link
Collaborator

@rth rth commented Nov 25, 2020

Backport of #461 to master.

@rth rth requested a review from maikia November 25, 2020 14:54
@agramfort
Copy link
Collaborator

not clear what this fixes. I see the plot here https://ramp.studio/event_plots/meg_datacamp2020 for example

@rth
Copy link
Collaborator Author

rth commented Nov 25, 2020

I'm not in that event so I don't see it. But for https://ramp.studio/events/air_passengers_py4ds2020/dashboard_submissions for instance I see,

image

so no graph, with a Uncaught SyntaxError: expected property name, got '{' syntax error in the JavaScript console. This fixes it.

@rth
Copy link
Collaborator Author

rth commented Nov 25, 2020

For https://ramp.studio/events/meg_datacamp2020/dashboard_submissions I also see no plots, with the same error both in Chrome and Firefox. So I'm not sure why it's working for you..

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #477 (c716a76) into master (a2f585f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   93.56%   93.54%   -0.02%     
==========================================
  Files          99       99              
  Lines        8496     8496              
==========================================
- Hits         7949     7948       -1     
- Misses        547      548       +1     
Impacted Files Coverage Δ
ramp-frontend/ramp_frontend/views/visualization.py 7.69% <0.00%> (ø)
ramp-engine/ramp_engine/base.py 92.30% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f585f...c716a76. Read the comment docs.

Copy link
Collaborator

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I can replicate !

@rth
Copy link
Collaborator Author

rth commented Nov 26, 2020

Merging with one approval as this should be very low risk and a useful bug fix.

@rth rth merged commit 94dd388 into paris-saclay-cds:master Nov 26, 2020
@rth rth deleted the fix-bokeh-plots-master branch November 26, 2020 17:18
maikia pushed a commit to maikia/ramp-board that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants