Catch suddenly terminated instances #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r on checking if the the training has finished
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 93.59% 93.61% +0.01%
==========================================
Files 99 99
Lines 8527 8552 +25
==========================================
+ Hits 7981 8006 +25
Misses 546 546
Continue to review full report at Codecov.
|
lucyleeow
approved these changes
Dec 8, 2020
|
Thx @maikia |
maikia
added a commit
that referenced
this pull request
Dec 16, 2020
* catching calledProcessError and if caught restarting the submission * catches CalledProcessError * add the test for the status being set to retry if called process error on checking if the the training has finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #487
spot instances might be terminated at any point in time by AWS. therefore the worker needs to catch any problem with connecting to the instance and put the submission back to the queue if the connection problem occurs (ie set its status to 'retry'.