Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Add /manage_users admin page with a list of users #538

Merged
merged 7 commits into from Sep 3, 2021

Conversation

rth
Copy link
Collaborator

@rth rth commented Jun 17, 2021

This adds /manage_users page accessible to admins, which allows to search within the user table without having to manually do DB queries.

image

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #538 (a7f9eb7) into master (a729de1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage   93.47%   93.48%   +0.01%     
==========================================
  Files         103      103              
  Lines        8867     8882      +15     
==========================================
+ Hits         8288     8303      +15     
  Misses        579      579              
Impacted Files Coverage Δ
ramp-frontend/ramp_frontend/tests/test_admin.py 100.00% <100.00%> (ø)
ramp-frontend/ramp_frontend/views/admin.py 85.97% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a729de1...a7f9eb7. Read the comment docs.

@kegl
Copy link
Collaborator

kegl commented Jul 2, 2021

Thanks @rth , the code LGTM. This is a very useful feature on xianti, I think it will also be for ramp.studio. @agramfort ?

@rth rth marked this pull request as draft July 16, 2021 11:20
@frcaud
Copy link
Collaborator

frcaud commented Jul 16, 2021

LGTM provided that CI issue is resolved. Thanks @rth.

@rth rth marked this pull request as ready for review September 3, 2021 07:54
@rth rth merged commit fca37ea into paris-saclay-cds:master Sep 3, 2021
@rth rth deleted the user-admin-page branch September 3, 2021 07:54
@frcaud
Copy link
Collaborator

frcaud commented Sep 3, 2021

Thanks @rth

rth added a commit to rth/ramp-board that referenced this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants