FIX encoding for new nbconvert version #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 81.75% 81.75%
=======================================
Files 133 133
Lines 4921 4921
=======================================
Hits 4023 4023
Misses 898 898
Continue to review full report at Codecov.
|
albertcthomas
changed the title
agramfort
approved these changes
Oct 25, 2020
|
thx @albertcthomas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appveyor is red now that nbconvert is installed with a version higher than 6. It was green when using a version < 6.
Trying to fix it by forcing utf8 encoding when reading the notebook. Note that the notebook is written to a file with an utf8 encoding (https://github.com/paris-saclay-cds/ramp-workflow/blob/master/rampwf/utils/notebook.py#L59)