Skip to content

Commit

Permalink
Updated CI (#26)
Browse files Browse the repository at this point in the history
Updated CI to use node 20 and unified the tests.

Updated docker image to use node 20.
  • Loading branch information
Bullrich committed Mar 6, 2024
1 parent 0119130 commit 991b75b
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 32 deletions.
56 changes: 26 additions & 30 deletions .github/workflows/javascript-test.yml
Original file line number Diff line number Diff line change
@@ -1,43 +1,39 @@
name: Continuous testing

on: [pull_request]
on:
pull_request:
push:
branches: ["main"]

jobs:
lint:
test:
strategy:
matrix:
command: [lint, build, test]
runs-on: ubuntu-latest
name: running ${{ matrix.command }}
steps:
- uses: actions/checkout@v3
- name: Use node 18
uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
- uses: c-hive/gha-yarn-cache@v2
- name: Install dependencies
run: yarn install --frozen-lockfile
- run: yarn run lint

build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Use node 18
uses: actions/setup-node@v3
node-version: 20
- name: Cache node modules
id: cache-npm
uses: actions/cache@v4
env:
cache-name: cache-node-modules
with:
node-version: 18
- uses: c-hive/gha-yarn-cache@v2
# npm cache files are stored in `~/.npm` on Linux/macOS
path: ~/.npm
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: ${{ runner.os }}-build-${{ env.cache-name }}-
- name: Install dependencies
run: yarn install --frozen-lockfile
- run: yarn run build
- run: yarn run ${{ matrix.command }}

test:
conclude:
runs-on: ubuntu-latest
name: All tests passed
needs: [test]
steps:
- uses: actions/checkout@v3
- name: Use node 18
uses: actions/setup-node@v3
with:
node-version: 18
- uses: c-hive/gha-yarn-cache@v2
- name: Install dependencies
run: yarn install --frozen-lockfile
- run: yarn run test
- run: echo '### Good job! All the tests passed 🚀' >> $GITHUB_STEP_SUMMARY
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18 as Builder
FROM node:20 as Builder

WORKDIR /action

Expand All @@ -10,7 +10,7 @@ COPY . .

RUN yarn run build

FROM node:18-slim
FROM node:20-slim

COPY --from=Builder /action/dist /action

Expand Down

0 comments on commit 991b75b

Please sign in to comment.