-
Notifications
You must be signed in to change notification settings - Fork 382
Conversation
This reverts commit af3cca0.
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
There is an additional condition that should be implemented (after discussing it with @NachoPal in element): Weights should be pushed to the same branch where the binary for benchmarks was compiled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alvicsam . I realised that we'll need an input to select the branch we want to use for building the binary, running the benchmarks and opening a PR with the new weights.
The flow would be as follows:
- Select branch release-parachains-vX.Y.Z -> Click Run benchmarks button
- The binary is built, benchmarks are run.
- When the new weights are ready, a PR is open against release-parachains-vX.Y.Z
- We review the PR and merge it to release-parachains-vX.Y.Z
@NachoPal I changed benchmarks jobs. Now they will appear only on pipelines that are related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What Benchmarking machine is used to run the benchmarks? |
|
PR adds manual benchmarks job. It's divided to 2 jobs:
benchmarks-build
which builds binary on a faster ci runners and passes tobenchmarks
job which execute benchmarks.The
benchmarks
job runs scriptbenchmarks-ci.sh
for statemine, statemint and westmint and creates PR on github with updated weights (example: #1138)Part of https://github.com/paritytech/ci_cd/issues/260
Closes #631