Make xcm-emulator test pass for new consensus hook

[NachoPal]

This PR tries to solve: #2703

Tests are not panicking anymore with slot info is inserted on block initialization, but now they are running into another issue. Tests are failing with included head not present in relay storage proof.

Should I add the rest of the hooks (on_finalize, etc)?

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2964712

[slumber]

We need a full parent header to be included into the storage proof. For example, this is how it's done for parachain system tests

cumulus/pallets/parachain-system/src/tests.rs

Lines 403 to 404 in 6141995

	let header = System::finalize();
	let head_data = relay_chain::HeadData(header.encode());

cumulus/pallets/parachain-system/src/tests.rs

Lines 347 to 351 in 6141995

	sproof_builder.included_para_head = self
	.included_para_head
	.clone()
	.unwrap_or_else(|| parent_head_data.clone())
	.into();

To my understanding, headers are not accessible from the runtime, so we need system pallet to be finalized.

[muharem]

I would say that the emulator should behave as close as possible to the real environment, while only mocking the network layer. on_finalize should also run for all pallets, in a right order.

[NachoPal]

bot fmt

[command-bot]

@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2989870 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-dd2ced3f-1709-486b-aa37-89165fcaa547 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2989870 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2989870/artifacts/download.

[NachoPal]

I dropped the idea of running all pallets on_initialized and on_finalized with AllPalletsWithSystem. The reason is I was running into more errors because of multiple reasons. One of them was the slot verification when using defaults pre-runtime digest. It forced me to manually build them + having to set inherent for timestamp etc...

I realised I was building something very specific for our runtimes using Aura and AuraExt. One of the goals of xcm-emulator is to be as generic as possible, so other parachains (that are maybe using another consensus system) can use it too.

I created this new issue #2734 to add on_initialize and on_finalize optional hooks to xcm-emulator.

The changes in this PR should be good enough to make the test pass, and therefore not being a blocker anymore.

Please merge it if you are ok with it.

[gilescope]

It's a closer emulation than what we've currently got so it gets my vote.

[slumber]

Thanks @NachoPal!