Transfer asset via bridge pallet xcm with dynamic fees and back-pressure #2997

bkontur · 2023-08-11T13:10:05Z

This PR extends asset transfer with pallet_xcm PR, adding dynamic fees and back-preassure mechanism.

You can review bridges subdirectory either here or in its dedicated PR in parity-bridges-common where it was originally developed.

TODO:

set/check static "base fee" in BridgeTable (according to ExportMessage calculation from BridgeHub)
set/verify default value for XcmBridgeHubRouterByteFee (actaully is TransactionByteFee) or setup governance call?
add possiblity to change XcmBridgeHubRouterByteFee via governance + test
set up benchmarks for router WeightInfo
add support/barrier for unpaid report_congestion + test
assert FeeManager charged fees in test when merged Introduce XcmFeesToAccount fee manager polkadot#7005
- search code for // TODO:check-parameter: change and assert in tests when (https://github.com/paritytech/polkadot/pull/7005) merged

8f86ec78b7 ".git/.scripts/commands/fmt/fmt.sh" ccf2f9483b Merge remote-tracking branch 'origin/polkadot-staging' into dynamic-fees-v1 f822ebc450 Dynamic fees v1: report congestion status to sending chain (#2318) add9fb1d53 added/fixed some docs 569a80f233 Rename LocalXcmChannel to XcmChannelStatusProvider (#2319) dc3618a4a5 Clippy e7cab6ab49 (Suggestion) Ability to externalize configuration for `ExporterFor` (#2313) c68467beff fmt 5d76f25311 use saturated_len where possible 7cc1470528 Update modules/xcm-bridge-hub-router/src/lib.rs 8d7a38a409 change log target for xcm bridge router pallet 773f93209f Revert "trigger CI" 48f1ba0323 trigger CI b26aa98d1e fixing spellcheck, clippy and rustdoc c467911a37 add new pallet to verify-pallets-build.sh ed72ebe62b get rid of redundant storage value 522bbc7ec4 benchmarks for pallet-xcm-bridge-hub-router 958243564d extension_reject_call_when_dispatcher_is_inactive 38cd8f3df3 fix other tests in the bridge-runtime-common b75e64fdf7 tests for new logic in the XcmBlobHaulerAdapter 4c741714cb tests for LocalXcmQueueMessageProcessor d99420e14c tests for LocalXcmQueueSuspender 084f551bb6 new tests for logic changes in messages pallet d9515f7317 use LocalXcmChannel in XcmBlobMessageDispatch d9a0c2e468 improvements and tests for palle-xcm-bridge-router c24301374a removed commented code eea610a875 pallet-xcm-bridge-hub-router 1fdac85a14 forbid mesage delivery transactions when the channel between target bridge hub and target asset hub is suspended 3c98c245ac OnMessageDelviered callback 65787da038 LocalXcmQueueManager + more adapters 74b48e2cc3 impl backpressure in the XcmBlobHaulerAdapter git-subtree-dir: bridges git-subtree-split: 8f86ec78b7747ba32807e8691f022edb4ad3040d

…sfer-asset-via-bridge-pallet-xcm-with-dynamic-fees

…r now)

Adjust test for paid or unpaid xcm matcher

svyatonik · 2023-08-15T07:10:42Z

parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs

+pub type XcmRouter = WithUniqueTopic<(
+	LocalXcmRouter,
+	// Router which wraps and sends xcm to BridgeHub to be delivered to the Polkadot GlobalConsensus
+	ToPolkadotXcmRouter,


@bkontur Just some random thought. Can you, please, confirm that noone can use the XCM pallet send (or something like that) to send the program with ExportMessage instruction from AH to sibling BH? Otherwise he could avoid paying the proper fee for that.

@svyatonik do you mean something like if any other sibling parachain send xcm::Transact(pallet_xcm::send(to_bridge_hub, ExportMessage(...))) ?

all AssetHubs have disabled pallet_xcm::send:

// We want to disallow users sending (arbitrary) XCMs from this chain. type SendXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, ()>; ... type XcmExecuteFilter = Nothing;

but I think I got your good point,
if above stuff will be allowed, we would charge origin by XcmpQueue router fee and not by ToPolkadotXcmRouter fee, if XcmpQueue fee will be enough and lower than ToPolkadotXcmRouter, then yes we could have a problem

I think also there is a simple solution for this:
pallet_xcm::send_xcm adds DescendOrigin, so if we adjust xcm filter on BridgeHubs e.g. do not allow DescendOrigin or allow only MultiLocation {parents: 1, interior: X1(Parachain(para_id))} pattern it should be enough

I trust your judgement here :) If we do not allow sending arbitrary messages to sibling BH now, then probably it is OK - just wanted to be sure. For v2 we won't need it (I assume), because we will be accepting messages from non-system parachains and (I guess) we don't want to force them to use something that is not strictly necessary (like disallowing programs with DescendOrigin instruction). Because in any case, we'll either need to support fishermens, or impl something like https://github.com/paritytech/parity-bridges-common/issues/2324 for activating backpressure

parachains/runtimes/assets/asset-hub-polkadot/src/xcm_config.rs

…dge_status)` for report congestion

…etection`

bkontur · 2023-08-16T13:27:01Z

bot bench cumulus-assets --subcommand=pallet --pallet=pallet_xcm_bridge_hub_router --runtime=asset-hub-kusama
bot bench cumulus-assets --subcommand=pallet --pallet=pallet_xcm_bridge_hub_router --runtime=asset-hub-polkadot

command-bot · 2023-08-16T13:27:06Z

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400837 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 34-c3c2d655-293d-4095-a2ec-8e927c2767d7 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-08-16T13:27:11Z

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400838 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-polkadot --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 35-d6b15980-47a9-45ac-bca9-2e8ae172ed52 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-08-16T13:53:40Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400837 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400837/artifacts/download.

command-bot · 2023-08-16T13:54:02Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-polkadot --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400838 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400838/artifacts/download.

…llet-xcm' into bko-transfer-asset-via-bridge-pallet-xcm-with-dynamic-fees

bkontur · 2023-08-16T19:55:55Z

bot rebase

paritytech-processbot · 2023-08-16T19:56:03Z

Error: Command 'Command { std: cd "/storage/repositories/cumulus" && "git" "merge" "origin/bko-transfer-asset-via-bridge-pallet-xcm" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

…llet-xcm' into bko-transfer-asset-via-bridge-pallet-xcm-with-dynamic-fees

bkontur · 2023-08-17T08:13:59Z

bot bench cumulus-assets --subcommand=pallet --pallet=pallet_xcm_bridge_hub_router --runtime=asset-hub-kusama
bot bench cumulus-assets --subcommand=pallet --pallet=pallet_xcm_bridge_hub_router --runtime=asset-hub-polkadot

command-bot · 2023-08-17T08:14:04Z

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406271 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 44-d8670105-e574-4ff2-a0fa-24b3944cdc66 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-08-17T08:14:09Z

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406272 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-polkadot --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 45-eb90cbbd-2544-4934-9478-8e8cd18af08a to cancel this command or bot cancel to cancel all commands in this pull request.

…=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router

command-bot · 2023-08-17T09:30:01Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406271 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406271/artifacts/download.

command-bot · 2023-08-17T09:30:44Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-polkadot --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406272 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3406272/artifacts/download.

…ulus/-/jobs/3406272

acatangiu

looks good except couple of comments

parachains/common/src/xcm_config.rs

acatangiu · 2023-08-18T13:38:07Z

parachains/runtimes/assets/asset-hub-kusama/src/lib.rs

@@ -769,6 +796,9 @@ construct_runtime!(
 		Multisig: pallet_multisig::{Pallet, Call, Storage, Event<T>} = 41,
 		Proxy: pallet_proxy::{Pallet, Call, Storage, Event<T>} = 42,

+		// Bridge utilities.
+		ToPolkadotXcmRouter: pallet_xcm_bridge_hub_router::<Instance1>::{Pallet, Storage, Call} = 43,


nit:

could leave room for a couple more generic utilities;

how many bridging pallets do we expect in AH? there will probably be some Snowfork-specific ones too?

Suggested change

ToPolkadotXcmRouter: pallet_xcm_bridge_hub_router::<Instance1>::{Pallet, Storage, Call} = 43,

ToPolkadotXcmRouter: pallet_xcm_bridge_hub_router::<Instance1>::{Pallet, Storage, Call} = 45,

parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs

parachains/runtimes/assets/asset-hub-polkadot/src/xcm_config.rs

bkontur added 4 commits August 10, 2023 15:49

Merge commit '429d6b09cab2379e1a118bc4d59dc8f935c5ae2d' into bko-tran…

6544a5c

…sfer-asset-via-bridge-pallet-xcm-with-dynamic-fees

[dynfees] Rococo/Wococo does not need congestion and dynamic fees (fo…

18b425a

…r now)

Adding paid xcm bridge hub router

a399514

Adjust test for paid or unpaid xcm matcher

bkontur force-pushed the bko-transfer-asset-via-bridge-pallet-xcm-with-dynamic-fees branch 3 times, most recently from f7a5fbc to c725400 Compare August 14, 2023 10:59

bkontur added 2 commits August 14, 2023 15:22

[dynfees] Implemented XcmChannelStatusProvider for XcmpQueue

e5a03a3

Allow to change XcmBridgeHubRouterByteFee by governance

025f109

bkontur force-pushed the bko-transfer-asset-via-bridge-pallet-xcm-with-dynamic-fees branch 2 times, most recently from af0a0c3 to 62f2878 Compare August 14, 2023 15:18

Adding paid xcm bridge hub router to AssetHubPolkadot

d48d27e

bkontur force-pushed the bko-transfer-asset-via-bridge-pallet-xcm-with-dynamic-fees branch from 62f2878 to d48d27e Compare August 14, 2023 15:30

bkontur added 2 commits August 14, 2023 22:41

Extended script for local run BHK/P

8b92cd7

Docs nits

43cda64

svyatonik changed the title ~~Transfer asset via bridge pallet xcm with dynamic fees and back-preassure~~ Transfer asset via bridge pallet xcm with dynamic fees and back-pressure Aug 15, 2023

svyatonik reviewed Aug 15, 2023

View reviewed changes

parachains/runtimes/assets/asset-hub-polkadot/src/xcm_config.rs Outdated Show resolved Hide resolved

bkontur added 9 commits August 15, 2023 12:05

Added XcmBridgeHubRouterCall::report_bridge_status encodings for AHK/P

e86d89e

Added test_report_bridge_status_call_compatibility for encodings

130646c

Allowed `xcm::Transact(pallet_xcm_bridge_hub_router::Call::report_bri…

c82f585

…dge_status)` for report congestion

Added const for XcmBridgeHubRouterTransactCallMaxWeight

05d504a

Added constant for base fee (with sanity check)

356969d

Introduced base delivery fee constants

0a54659

Congestion messages as Optional to turn on/off `supports_congestion_d…

824a480

…etection`

Fix for BHRo/Wo

6363103

Benchmarks for router

7fd6d26

svyatonik approved these changes Aug 16, 2023

View reviewed changes

bkontur added 2 commits August 16, 2023 13:34

Benchmarks setup for router

0f45881

Fix origin for benchmarks

4bfd8d2

bkontur added 2 commits August 16, 2023 15:15

Fix for benchmarks - need hrmp opened

c624475

Removed WeightInfo TODO

9b045f9

bkontur added 2 commits August 16, 2023 16:06

Merge remote-tracking branch 'origin/bko-transfer-asset-via-bridge-pa…

5d7b413

…llet-xcm' into bko-transfer-asset-via-bridge-pallet-xcm-with-dynamic-fees

Fmt

7c87577

bkontur added 2 commits August 16, 2023 21:57

Merge remote-tracking branch 'origin/bko-transfer-asset-via-bridge-pa…

969a48f

…llet-xcm' into bko-transfer-asset-via-bridge-pallet-xcm-with-dynamic-fees

Merge remote-tracking branch 'origin/bko-transfer-asset-via-bridge-pa…

7dd0ea9

…llet-xcm' into bko-transfer-asset-via-bridge-pallet-xcm-with-dynamic-fees

bkontur marked this pull request as ready for review August 17, 2023 08:13

bkontur added the A0-please_review Pull request needs code review. label Aug 17, 2023

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

3f7c7f7

…=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router

Apply git patch from job: https://gitlab.parity.io/parity/mirrors/cum…

a5f04fe

…ulus/-/jobs/3406272

acatangiu mentioned this pull request Aug 25, 2023

[P-K Bridge] AssetHubPolkadot<>AssetHubKusama asset transfer (via pallet-xcm) paritytech/parity-bridges-common#2431

Closed

4 tasks

acatangiu self-requested a review August 17, 2023 13:32

acatangiu reviewed Aug 18, 2023

View reviewed changes

paritytech-ci requested review from a team August 18, 2023 14:13

Apply suggestions from code review

cbcfb6f

acatangiu approved these changes Aug 21, 2023

View reviewed changes

bkontur mentioned this pull request Sep 1, 2023

[asset-hubs/bridge-hubs] Bridging Polkadot Asset Hub <-> Kusama Asset Hub to enable asset transfer of KSMs/DOTs paritytech/polkadot-sdk#1352

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transfer asset via bridge pallet xcm with dynamic fees and back-pressure #2997

Transfer asset via bridge pallet xcm with dynamic fees and back-pressure #2997

bkontur commented Aug 11, 2023 •

edited

Loading

svyatonik Aug 15, 2023

bkontur Aug 15, 2023

svyatonik Aug 15, 2023

bkontur commented Aug 16, 2023

command-bot bot commented Aug 16, 2023 •

edited

Loading

command-bot bot commented Aug 16, 2023 •

edited

Loading

command-bot bot commented Aug 16, 2023

command-bot bot commented Aug 16, 2023

bkontur commented Aug 16, 2023

paritytech-processbot bot commented Aug 16, 2023

bkontur commented Aug 17, 2023

command-bot bot commented Aug 17, 2023 •

edited

Loading

command-bot bot commented Aug 17, 2023 •

edited

Loading

command-bot bot commented Aug 17, 2023

command-bot bot commented Aug 17, 2023

acatangiu left a comment

acatangiu Aug 18, 2023

	ToPolkadotXcmRouter: pallet_xcm_bridge_hub_router::<Instance1>::{Pallet, Storage, Call} = 43,
	ToPolkadotXcmRouter: pallet_xcm_bridge_hub_router::<Instance1>::{Pallet, Storage, Call} = 45,

Transfer asset via bridge pallet xcm with dynamic fees and back-pressure #2997

Are you sure you want to change the base?

Transfer asset via bridge pallet xcm with dynamic fees and back-pressure #2997

Conversation

bkontur commented Aug 11, 2023 • edited Loading

svyatonik Aug 15, 2023

Choose a reason for hiding this comment

bkontur Aug 15, 2023

Choose a reason for hiding this comment

svyatonik Aug 15, 2023

Choose a reason for hiding this comment

bkontur commented Aug 16, 2023

command-bot bot commented Aug 16, 2023 • edited Loading

command-bot bot commented Aug 16, 2023 • edited Loading

command-bot bot commented Aug 16, 2023

command-bot bot commented Aug 16, 2023

bkontur commented Aug 16, 2023

paritytech-processbot bot commented Aug 16, 2023

bkontur commented Aug 17, 2023

command-bot bot commented Aug 17, 2023 • edited Loading

command-bot bot commented Aug 17, 2023 • edited Loading

command-bot bot commented Aug 17, 2023

command-bot bot commented Aug 17, 2023

acatangiu left a comment

Choose a reason for hiding this comment

acatangiu Aug 18, 2023

Choose a reason for hiding this comment

bkontur commented Aug 11, 2023 •

edited

Loading

command-bot bot commented Aug 16, 2023 •

edited

Loading

command-bot bot commented Aug 16, 2023 •

edited

Loading

command-bot bot commented Aug 17, 2023 •

edited

Loading

command-bot bot commented Aug 17, 2023 •

edited

Loading