Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add extrincic ordering check to CI #629

Merged
merged 7 commits into from
Sep 30, 2021

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Sep 29, 2021

This PR adds running a manual check for the extrinsic ordering.
A test run can be seen here: https://github.com/chevdor/cumulus/actions/runs/1287438927

What currently fails for some reason atm is not critical, the CI seems to fail killing the polkadot-collator (it works fine with polkadot).

@chevdor chevdor marked this pull request as ready for review September 29, 2021 15:28
@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). M1-ci labels Sep 29, 2021
required: true
binary_url:
description: A url to a Linux binary for the node containing the runtime to test
default: https://github.com/paritytech/cumulus/releases/download/statemine_v3/polkadot-collator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is hard-coded to v3, we might want to default to latest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an example to show the pattern. In general, users will NOT use latest, they will want to point at a specific version so having the version show up makes it easier. Once we have v4 released, it will be obviouls how to change the default string. If I replace with latest, the user will not (easily) know whether to use 3 or v3 for instance.

Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but in general, it's not great to separate the pipelines making them run independently

@chevdor
Copy link
Contributor Author

chevdor commented Sep 30, 2021

it's not great to separate the pipelines making them run independently

I agree. For now, many of the steps are manual. The reaons is that instead of going right away for a big CI pipeline that will sill surely fail in many places, it is much simpler to start formalizing with independant pipelines that can be started manually, troubleshooted and re-started indepdently. Once everything works 100%, we can collapse all of those into one single pipeline if that still makes sense.

@chevdor chevdor merged commit 1a6491b into paritytech:master Sep 30, 2021
@chevdor chevdor deleted the wk-extrinsic-ordering branch September 30, 2021 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants