Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more trace loggings #110

Closed
wants to merge 1 commit into from

Conversation

xlc
Copy link

@xlc xlc commented Mar 2, 2020

Improves paritytech/substrate#4921

This allow me to know which validators are not participating grandpa. It can be hard to know because they are still doing babe fine.

@parity-cla-bot
Copy link

It looks like @xlc signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@andresilva
Copy link
Contributor

@xlc I totally get why you are doing this as I have done the same, I actually wrote some code that would log only the authorities that didn't vote. Currently there is no better way to get this information out (hence why we're doing paritytech/substrate#4921), but I think this is too much to be logging by default (e.g. on Kusama we are running all our nodes with trace logging and with 160 validators this would just spam the logs a lot). So I would suggest that we don't merge these changes and instead you just keep them locally for debugging.

@xlc
Copy link
Author

xlc commented Mar 10, 2020

Make sense. Will do.

@xlc xlc closed this Mar 10, 2020
@ltfschoen
Copy link

ltfschoen commented Mar 16, 2020

I think this would have been helpful, just give users the ability to enable/disable this level of logging verbosity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants