Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Metadata v8-11? #27

Closed
insipx opened this issue Oct 11, 2021 · 3 comments · Fixed by #28
Closed

Adding Metadata v8-11? #27

insipx opened this issue Oct 11, 2021 · 3 comments · Fixed by #28
Assignees
@insipx

Comments

@insipx
Copy link
Contributor

insipx commented Oct 11, 2021 •
edited

I've got metadata versions v8-v11 here and recently converted them to use what i could from frame-metadata. I think it would now be pretty easy for me to make a PR to this repo and add those metadata versions if it is wanted/needed. I believe V8 to be the first metadata version that Kusama uses
@ascjones
Copy link
Member

Yeah I think that would be super useful for historic data. Although we may want to consider how we can reduce the number of features as we have a feature per version currently, Maybe we could hide all historical ones behind a single feature.

@insipx
Copy link
Contributor Author

insipx commented Oct 11, 2021

yeah I would be up for creating a 'historical' or 'legacy' feature if that works

@bkchr
Copy link
Member

bkchr commented Oct 11, 2021

Sounds good IMO

@insipx insipx self-assigned this Oct 11, 2021
This was referenced Oct 20, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@insipx insipx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metadata versions v8-v11 paritytech/frame-metadata
3 participants
@ascjones @bkchr @insipx