Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to version v1.1.1 #21

Merged
merged 1 commit into from
Apr 3, 2024
Merged

updated to version v1.1.1 #21

merged 1 commit into from
Apr 3, 2024

Conversation

Bullrich
Copy link
Collaborator

@Bullrich Bullrich commented Apr 3, 2024

As per the docs, unless we update those two files, the new version will not be deployed as a Docker package.

Required to have #20's change.

Also, we need this to be merged before polkadot-fellows/runtimes#265, else it will not work as the package doesn't currently exist.

@Bullrich Bullrich self-assigned this Apr 3, 2024
@Bullrich Bullrich requested a review from a team as a code owner April 3, 2024 08:43
@Bullrich Bullrich enabled auto-merge (squash) April 3, 2024 08:43
@mordamax
Copy link
Contributor

mordamax commented Apr 3, 2024

@Bullrich is there a way to make this change automatic as part of release actions?

@Bullrich
Copy link
Collaborator Author

Bullrich commented Apr 3, 2024

@Bullrich is there a way to make this change automatic as part of release actions?

Yes, technically we can push this change in an automatic mode.

But right now we need to have this change available before polkadot-fellows/runtimes#265 gets merged

@Bullrich Bullrich merged commit a5b239d into main Apr 3, 2024
8 checks passed
@Bullrich Bullrich deleted the version/1.1.1 branch April 3, 2024 09:14
@mordamax
Copy link
Contributor

mordamax commented Apr 3, 2024

@Bullrich is there a way to make this change automatic as part of release actions?

Yes, technically we can push this change in an automatic mode.

But right now we need to have this change available before polkadot-fellows/runtimes#265 gets merged

oops i thought i approved and commented, didn't have intent to block it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants