Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for labels #53

Merged
merged 14 commits into from
Jan 26, 2023

Conversation

Bullrich
Copy link
Contributor

Added support for labeling. The system can now evaluate the new issues based on the existence of labels, allowing us to combine unlabeled and labeled issue behavior.

This commit closes #45

Updated README to explain how to set up the labeling system and showing an example of how to combine different configurations in one file.

Extended unit tests to handle all predicted behaviors.

@Bullrich Bullrich added this to the GitHub Action port milestone Jan 25, 2023
@Bullrich Bullrich self-assigned this Jan 25, 2023
@Bullrich Bullrich requested a review from a team as a code owner January 25, 2023 11:25
action.yml Outdated Show resolved Hide resolved
src/synchronizer.ts Outdated Show resolved Hide resolved
src/synchronizer.ts Outdated Show resolved Hide resolved
src/github/types.ts Outdated Show resolved Hide resolved
src/synchronizer.ts Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@Bullrich Bullrich requested a review from rzadp January 26, 2023 11:53
README.md Outdated
# The value to modify in the project field
project_value: To do
# Optional, labels to work with.
# If this value is set, the system will ignore any issue that doesn't contain that label(s).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
sorry, may be that's me, i had to re-read this description to get it right few times :) sounds like there's a double negative structure "ignore" / "doesn't contain"
could it be put like "If label(s) provided, action will apply project fields to only issues with such labels"

Copy link
Contributor Author

@Bullrich Bullrich Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I'll reword it before merging!

@Bullrich Bullrich merged commit f217b9f into paritytech:action-migration Jan 26, 2023
@Bullrich Bullrich deleted the labels-support branch January 26, 2023 12:33
Bullrich added a commit that referenced this pull request Mar 20, 2023
Added support for labeling. The system can now evaluate the new issues based on the existence of labels, allowing us to combine unlabeled and labeled issue behavior.

This commit closes #45

Updated `README` to explain how to set up the labeling system and showing an example of how to combine different configurations in one file.

Extended unit tests to handle all predicted behaviors.
Bullrich added a commit that referenced this pull request Mar 21, 2023
Added support for labeling. The system can now evaluate the new issues based on the existence of labels, allowing us to combine unlabeled and labeled issue behavior.

This commit closes #45

Updated `README` to explain how to set up the labeling system and showing an example of how to combine different configurations in one file.

Extended unit tests to handle all predicted behaviors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants