Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize call_runtime #1749

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Stabilize call_runtime #1749

merged 4 commits into from
Jun 1, 2023

Conversation

agryaznov
Copy link
Contributor

This host function is now stabilized in the pallet.

So we remove the feature flag and comments stating it's unstable.

@agryaznov agryaznov marked this pull request as draft April 13, 2023 15:02
@agryaznov agryaznov marked this pull request as ready for review April 13, 2023 15:19
@agryaznov agryaznov marked this pull request as draft April 13, 2023 15:27
@agryaznov
Copy link
Contributor Author

In order to make e2e test for the new function pass, we need to add pallet_balances::pallet::Call::transfer_allow_death dispatchable to the substrate-contracts-node's runtime CallFilter

@SkymanOne
Copy link
Contributor

In order to make e2e test for the new function pass, we need to add pallet_balances::pallet::Call::transfer_allow_death dispatchable to the substrate-contracts-node's runtime CallFilter

Well. We just need to update substrate contracts node.

@agryaznov
Copy link
Contributor Author

Well. We just need to update substrate contracts node.

update for the contracts-node: paritytech/substrate-contracts-node#186

@agryaznov agryaznov marked this pull request as ready for review May 26, 2023 15:06
@agryaznov
Copy link
Contributor Author

ci: substrate-contracts-node has been updated, we need to wait until fresh ink-ci-linux docker image is published with the new version of it.

@codecov-commenter
Copy link

Codecov Report

Merging #1749 (e267dd1) into master (8bb4b40) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   52.14%   52.09%   -0.05%     
==========================================
  Files         207      207              
  Lines        6657     6657              
==========================================
- Hits         3471     3468       -3     
- Misses       3186     3189       +3     
Impacted Files Coverage Δ
crates/env/src/api.rs 37.31% <ø> (ø)
crates/env/src/backend.rs 78.12% <ø> (ø)
crates/env/src/engine/off_chain/impls.rs 46.82% <ø> (ø)
crates/ink/src/env_access.rs 9.09% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants