Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert precise version specs and use new trybuild #345

Merged
merged 10 commits into from
Mar 12, 2020
Merged

Conversation

ascjones
Copy link
Collaborator

Latest version of trybuild includes this fix dtolnay/trybuild#54, so should no longer require the precise versions introduced in #343.

@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   12.28%   12.28%           
=======================================
  Files           7        7           
  Lines         464      464           
=======================================
  Hits           57       57           
  Misses        407      407

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2cb91...d28be54. Read the comment docs.

core/derive/tests/compile_tests.rs Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
@ascjones ascjones marked this pull request as ready for review March 11, 2020 16:39
@ascjones ascjones dismissed Robbepop’s stale review March 11, 2020 16:40

reverted all troublsehooting changes

@ascjones ascjones requested a review from Robbepop March 11, 2020 16:40
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robbepop Robbepop merged commit 0075806 into master Mar 12, 2020
@Robbepop Robbepop deleted the aj-trybuild branch March 12, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants