Implement the Error trait on ws Error type #117
Conversation
|
|
||
| impl ::std::error::Error for Error { | ||
| fn description(&self) -> &str { | ||
| "Starting the JSON-RPC WebSocket server failed" |
There was a problem hiding this comment.
Why not delegate to wrapped errors?
There was a problem hiding this comment.
I wanted them to work the same as the http errors. Also a chain of errors (this is one error and it contains a cause that is another error) should not just chain down transparently. The intermediate steps in the chain must have relevant information, otherwise there is no information why one got the bottom level error one got.
Instead of just delegating this down one might even want to change the display implementation to be "Starting the JSON-RPC WebSocket server failed: {}" and then format in the cause.
There was a problem hiding this comment.
I have been looking in the rustc code for any standard on how the description and Display are implemented. But I could not find a common denominator for enums containing sub-errors.
|
Could you merge with latest master so that we can see that the tests are not failing? |
|
@tomusdrw It is based on the latest master? Or should I merge it with master on my fork, what does that help with? |
|
@tomusdrw Latest master fails with the same error on my machine as well. |
|
Oh, ok sorry. It's probably caused by a |
|
Sorry once again, actually I thought that the fix is already merged, but I just made a PR: #119 |
|
@tomusdrw Fixed. Should hopefully build now. |
|
Now nightly crashes on something else. But I get that locally as well. It's a bug that I think is reported on rustc already. |
|
Yeah, the crash is irrelevant. Thank you so much for the PR! |
Implement the Error trait on the websocket server error type. Same reason as in #97