Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPTIONS request 'Content-type' should not be json #58

Merged
merged 2 commits into from Mar 7, 2017
Merged

OPTIONS request 'Content-type' should not be json #58

merged 2 commits into from Mar 7, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2017

Because of CORS browser send OPTIONS request and failed with '415 Unsupported Media Type'.

Because of CORS browser send OPTIONS request and failed with '415 Unsupported Media Type'.
@tomusdrw
Copy link
Contributor

tomusdrw commented Mar 6, 2017

Looks good. Would be nice to include a test case for this (if you don't have time I'll prepare it tomorrow).

Also probably just altering the order of conditions should be sufficient (i.e. moving content type validation after is_options handling)

@tomusdrw tomusdrw requested a review from rphmeier March 6, 2017 23:42
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. @rphmeier could you also have a look?

@debris
Copy link
Contributor

debris commented Mar 7, 2017

lgtm

@tomusdrw tomusdrw merged commit 3db8455 into paritytech:master Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants