Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in select_with_weak future #610

Merged
merged 1 commit into from Jan 27, 2021
Merged

fix typo in select_with_weak future #610

merged 1 commit into from Jan 27, 2021

Conversation

nanne007
Copy link
Contributor

@nanne007 nanne007 commented Jan 27, 2021 •
edited

the typo causes subscription not working when in ipc transport.
The typo is introduced in https://github.com/paritytech/jsonrpc/pull/603/files#diff-b90d8d4d872fefee6d3c05a2a5ea994240ff6bc1cc119d38472a27e73335f4cdR84

@nanne007 nanne007 mentioned this pull request Jan 27, 2021
Merged
niklasad1
niklasad1 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, LGTM

@Xanewok
Copy link
Contributor

Xanewok commented Jan 27, 2021

Oops, sorry about that, good catch!

@Xanewok Xanewok merged commit 5d6ba66 into paritytech:master Jan 27, 2021
@nanne007 nanne007 deleted the fix/ipc-subscribe branch January 27, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

@Xanewok Xanewok Xanewok approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nanne007 @Xanewok @tomusdrw @niklasad1