New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare for client release #215
Conversation
ws-client/src/lib.rs
Outdated
@@ -1,3 +1,9 @@ | |||
#![warn(missing_debug_implementations, missing_docs, rust_2018_idioms, unreachable_pub)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should agree on a standard here with @maciejhirsz too. I suggest we make missing_docs
and unreachable_pub
errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with missing_docs
and unreachable_pub
, rust_2018_idioms
seems overly pendantic with elided lifetimes (I'd rather have Cow<str>
than Cow<'_, str>
, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep it as warn
because deny/forbid
would force it stop compile on new toolchains as rustc
gets smarter :)
forbid(warnings) in substrate is an example of this :)
Co-authored-by: David <dvdplm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one nitpick on lints that we just talked about with @niklasad1 :)
ws-client/src/lib.rs
Outdated
@@ -1,3 +1,9 @@ | |||
#![warn(missing_debug_implementations, missing_docs, rust_2018_idioms, unreachable_pub)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with missing_docs
and unreachable_pub
, rust_2018_idioms
seems overly pendantic with elided lifetimes (I'd rather have Cow<str>
than Cow<'_, str>
, etc.).
The PR prepares for a alpha client release: