Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

needless panic during deserialization? #105

Closed
Parth opened this issue Jan 23, 2022 · 1 comment · Fixed by #110
Closed

needless panic during deserialization? #105

Parth opened this issue Jan 23, 2022 · 1 comment · Fixed by #110

Comments

@Parth
Copy link

Parth commented Jan 23, 2022

https://github.com/paritytech/libsecp256k1/blob/master/src/lib.rs#L363

I believe we can just return an err here, @sorpaas would you take a PR that fixes this, or is there something I don't know about why this needs to panic?
@sorpaas
Copy link
Member

sorpaas commented Jan 23, 2022

Yes. Appreciate a fix!

@steverusso steverusso mentioned this issue Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bincode deserialization steverusso/libsecp256k1
2 participants
@Parth @sorpaas