initial support for bip30 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
reviewed
Nov 26, 2016
| @@ -68,6 +68,16 @@ impl ChainVerifier { | |||
|
|
|||
| let coinbase_spends = block.transactions()[0].total_spends(); | |||
|
|
|||
| // bip30 | |||
| // TODO: add exceptions | |||
There was a problem hiding this comment.
we need to add exception right away, or it will fail on mainnet?
NikVolf
reviewed
Nov 26, 2016
| @@ -84,6 +84,8 @@ pub enum TransactionError { | |||
| SigopsP2SH(usize), | |||
| /// Coinbase transaction is found at position that is not 0 | |||
| MisplacedCoinbase(usize), | |||
| /// Not fully spent transaction with the same hash already exists. | |||
| BIP30, | |||
There was a problem hiding this comment.
Will prefer actual reason of fail instead of bip30 reference which is quite large, but it is just me
|
fixed tests, syncing is now stuck at b73 |
NikVolf
reviewed
Nov 27, 2016
| @@ -28,6 +29,11 @@ impl ConsensusParams { | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| pub fn is_bip30_expcetion(&self, hash: &H256, height: u32) -> bool { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in
db/src/storage.rsare only idiomatic