This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
100% test coverage, issue 82, refactoring, documentation #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snd
changed the title
Issue 82 - improve contract code
Issue 82 - improve contract code and documentation
Jan 13, 2018
…ignature that is too short
snd
changed the title
Issue 82 - improve contract code and documentation
Issue 82 - improve contract code, documentation and test coverage
Jan 13, 2018
…and doesn't break for numbers with more than 8 digits
snd
changed the title
Issue 82 - improve contract code, documentation and test coverage
100% test coverage, issue 82, refactoring, documentation
Jan 15, 2018
debris
approved these changes
Jan 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! 🙌
This was referenced Jan 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpers
librarytoString
(now calleduintToString
) with one that works correctly for0
, integers with more than 8 digits and also uses less gas (before: https://travis-ci.org/paritytech/parity-bridge/jobs/328970765#L1482, after: https://travis-ci.org/paritytech/parity-bridge/jobs/328980140#L1466). the new implementation is thoroughly tested