Make relay generic over source/target chains #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
Apr 7, 2020
HCastano
approved these changes
Apr 8, 2020
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
Deactivate mdns for polkadot node as it prevents the process to exit properly Fixes #57
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* renamed to-be-generic files * make everything required generic over source/target chains * some more fixes * cargo fmt --all * trait functions -> trait constants * cargo --fmt --all
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* renamed to-be-generic files * make everything required generic over source/target chains * some more fixes * cargo fmt --all * trait functions -> trait constants * cargo --fmt --all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to implement Substrate -> Ethereum headers synchronization, which is required to test solidity contract (#50) in action. The synchronization process would be almost the same (the biggest difference would be the extra header data - tx receipts vs justification) as the
eth-to-sub, so this PR mostly just moves code around + makes it generic over chains (i.e. instead ofethereum_headers.rsthere's now genericheaders.rs).Also: there's now no default mode for the relay - you should specify subcommand. Currently the only subcommand is
eth-to-sub. Next PRs will introducesub-to-ethmode.