-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration of cargo-spellcheck #832
Closed
Closed
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3078ccd
feat: added initial configuration of cargo-spellcheck
93fea8c
feat: added initial configuration of cargo-spellcheck
8f65bf9
feat: added specific words for a bridge
TomaszWaszczyk 1596638
feat(configuration): added cargo-spellcheck to CI as a new job
TomaszWaszczyk 56d7187
Update .github/workflows/lint.yml
57419c2
feat(config): change a way to install cargo-spellcheck on CI
TomaszWaszczyk 486a96f
feat(configuration): better naming for the job: "Run spellcheck"
TomaszWaszczyk 53cc84b
Update .github/workflows/lint.yml
2148246
feat(config): added: to increase verbosity add -v (multiple) to incre…
TomaszWaszczyk 1e3947a
feat(config): added: to increase verbosity add -vv (multiple) to incr…
TomaszWaszczyk 2c9748e
feat(config): first batch of real changes
TomaszWaszczyk 13e6331
feat(config): second batch of real changes
TomaszWaszczyk 91d06eb
feat(config): try to solve single hunspell quirk
TomaszWaszczyk d839709
Merge branch 'master' of github.com:paritytech/parity-bridges-common
TomaszWaszczyk 6d4f949
feat(sparta): this is sparta
TomaszWaszczyk ac41edd
Merge remote-tracking branch 'upstream/master'
TomaszWaszczyk 992d00b
Revert "Add pruning to bechmarks & update weights. (#918)"
TomaszWaszczyk File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| 90 | ||
| annualised/MS | ||
| Apache-2.0/M | ||
| api/SM | ||
| API/SM | ||
| APIs | ||
| async | ||
| BFT/M | ||
| bitfield/MS | ||
| blake2/MS | ||
| blockchain/MS | ||
| borked | ||
| BTC/S | ||
| CLI/MS | ||
| config/MS | ||
| crypto/MS | ||
| customizable/B | ||
| debian/M | ||
| decodable/MS | ||
| DOT/S | ||
| ed25519 | ||
| enum/MS | ||
| ERC-20 | ||
| ethereum/MS | ||
| externality/MS | ||
| extrinsic/MS | ||
| extrinsics | ||
| fedora/M | ||
| GiB/S | ||
| GPL/M | ||
| GPLv3/M | ||
| Handler/MS | ||
| https | ||
| inherent/MS | ||
| initialize/RG | ||
| instantiate/B | ||
| intrinsic/MS | ||
| intrinsics | ||
| io | ||
| js | ||
| keccak256/M | ||
| KSM/S | ||
| kusama/S | ||
| KYC/M | ||
| merkle/MS | ||
| misbehavior/SM | ||
| misbehaviors | ||
| MIT/M | ||
| multivalidator/SM | ||
| oneshot/MS | ||
| others' | ||
| parablock/MS | ||
| parachain/MS | ||
| parameterize/D | ||
| polkadot/MS | ||
| pov-block/MS | ||
| PoV/MS | ||
| promethius | ||
| promethius' | ||
| provisioner/MS | ||
| redhat/M | ||
| repo/MS | ||
| RPC/MS | ||
| runtime/MS | ||
| rustc/MS | ||
| sr25519 | ||
| struct/MS | ||
| subsystem/MS | ||
| subsystems' | ||
| taskmanager/MS | ||
| teleport/RG | ||
| teleportation/SM | ||
| teleporter/SM | ||
| teleporters | ||
| testnet/MS | ||
| trie/MS | ||
| trustless/Y | ||
| ubuntu/M | ||
| union/MSG | ||
| unservable/B | ||
| validator/SM | ||
| w3f/MS | ||
| wasm/M | ||
| WND/S | ||
| XCM/S | ||
| XCMP/M | ||
| include/BG | ||
| isolate/BG | ||
| Rialto | ||
| Millau | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| [hunspell] | ||
| lang = "en_US" | ||
| search_dirs = ["."] | ||
| extra_dictionaries = ["lingua.dic"] | ||
|
|
||
| [hunspell.quirks] | ||
| # `Type`'s | ||
| # 5x | ||
| transform_regex = ["^'([^\\s])'$", "^[0-9]+(?:\\.[0-9]*)?x$", "^'s$", "^\\+$"] | ||
| allow_concatenation = true | ||
| allow_dashes = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, where'd you get this list from?
Also, what's with the
/<letter>at the end of certain words?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is kinda...it is called
Hunspelland by that letters it is allowed to specify kind of dictionary like "en_US". Paste from the documentation:Source: https://www.chromium.org/developers/how-tos/editing-the-spell-checking-dictionaries
What is the source of the list? Well, long story short, around 2 months ago I was thinking that the task will take me ~1h and started to do it, but it was not so simple and was needed to leave it, but I to follow and look at Parity's repositories and I found that PR: https://github.com/paritytech/polkadot/pull/1841/files and my dream is to do at least one merge/ed PR and when I saw the PR I immediately made my PR.
That is it, that's the story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't fully get it, but good to know there's a source for the strangeness 😅
Haha, sounds good! Keep in mind that you will need to add some "bridge" specific words in there though (e.g our test networks Rialto and Millau). I'm not sure what other false positives you'll get, but I imagine there'll be a few.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spellcheck.mp4
@HCastano I wanted to check output from the commands like in recording but I got empty output, I have missed something all it works like supposed to work?