-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration of cargo-spellcheck #832
Changes from 8 commits
3078ccd
93fea8c
8f65bf9
1596638
56d7187
57419c2
486a96f
53cc84b
2148246
1e3947a
2c9748e
13e6331
91d06eb
d839709
6d4f949
ac41edd
992d00b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
90 | ||
annualised/MS | ||
Apache-2.0/M | ||
api/SM | ||
API/SM | ||
APIs | ||
async | ||
BFT/M | ||
bitfield/MS | ||
blake2/MS | ||
blockchain/MS | ||
borked | ||
BTC/S | ||
CLI/MS | ||
config/MS | ||
crypto/MS | ||
customizable/B | ||
debian/M | ||
decodable/MS | ||
DOT/S | ||
ed25519 | ||
enum/MS | ||
ERC-20 | ||
ethereum/MS | ||
externality/MS | ||
extrinsic/MS | ||
extrinsics | ||
fedora/M | ||
GiB/S | ||
GPL/M | ||
GPLv3/M | ||
Handler/MS | ||
https | ||
inherent/MS | ||
initialize/RG | ||
instantiate/B | ||
intrinsic/MS | ||
intrinsics | ||
io | ||
js | ||
keccak256/M | ||
KSM/S | ||
kusama/S | ||
KYC/M | ||
merkle/MS | ||
misbehavior/SM | ||
misbehaviors | ||
MIT/M | ||
multivalidator/SM | ||
oneshot/MS | ||
others' | ||
parablock/MS | ||
parachain/MS | ||
parameterize/D | ||
polkadot/MS | ||
pov-block/MS | ||
PoV/MS | ||
promethius | ||
promethius' | ||
provisioner/MS | ||
redhat/M | ||
repo/MS | ||
RPC/MS | ||
runtime/MS | ||
rustc/MS | ||
sr25519 | ||
struct/MS | ||
subsystem/MS | ||
subsystems' | ||
taskmanager/MS | ||
teleport/RG | ||
teleportation/SM | ||
teleporter/SM | ||
teleporters | ||
testnet/MS | ||
trie/MS | ||
trustless/Y | ||
ubuntu/M | ||
union/MSG | ||
unservable/B | ||
validator/SM | ||
w3f/MS | ||
wasm/M | ||
WND/S | ||
XCM/S | ||
XCMP/M | ||
include/BG | ||
isolate/BG | ||
Rialto | ||
Millau |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
[hunspell] | ||
lang = "en_US" | ||
search_dirs = ["."] | ||
extra_dictionaries = ["lingua.dic"] | ||
|
||
[hunspell.quirks] | ||
# `Type`'s | ||
# 5x | ||
transform_regex = ["^'([^\\s])'$", "^[0-9]+(?:\\.[0-9]*)?x$", "^'s$", "^\\+$"] | ||
allow_concatenation = true | ||
allow_dashes = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,3 +41,28 @@ jobs: | |
with: | ||
command: fmt | ||
args: --all -- --check | ||
check-spellcheck: | ||
name: Check For Spelling and/or Grammar Mistakes | ||
runs-on: ubuntu-latest | ||
env: | ||
RUST_BACKTRACE: full | ||
steps: | ||
- name: Cancel Previous Runs | ||
uses: styfle/cancel-workflow-action@0.4.1 | ||
with: | ||
access_token: ${{ github.token }} | ||
|
||
- name: Checkout sources & submodules | ||
uses: actions/checkout@master | ||
with: | ||
fetch-depth: 5 | ||
submodules: recursive | ||
|
||
- name: Add cargo-spellcheck | ||
run: cargo install cargo-spellcheck | ||
|
||
- name: Run spellcheck | ||
uses: actions-rs/cargo@master | ||
with: | ||
command: spellcheck | ||
args: check -m 1 | ||
TomaszWaszczyk marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. consider adding There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have looked at the docs and there is written:
That is why I added There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, where'd you get this list from?
Also, what's with the
/<letter>
at the end of certain words?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is kinda...it is called
Hunspell
and by that letters it is allowed to specify kind of dictionary like "en_US". Paste from the documentation:Source: https://www.chromium.org/developers/how-tos/editing-the-spell-checking-dictionaries
What is the source of the list? Well, long story short, around 2 months ago I was thinking that the task will take me ~1h and started to do it, but it was not so simple and was needed to leave it, but I to follow and look at Parity's repositories and I found that PR: https://github.com/paritytech/polkadot/pull/1841/files and my dream is to do at least one merge/ed PR and when I saw the PR I immediately made my PR.
That is it, that's the story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't fully get it, but good to know there's a source for the strangeness 😅
Haha, sounds good! Keep in mind that you will need to add some "bridge" specific words in there though (e.g our test networks Rialto and Millau). I'm not sure what other false positives you'll get, but I imagine there'll be a few.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spellcheck.mp4
@HCastano I wanted to check output from the commands like in recording but I got empty output, I have missed something all it works like supposed to work?