Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity-util-mem: export MallocShallowSizeOf #399

Merged
merged 2 commits into from
Jun 19, 2020
Merged

parity-util-mem: export MallocShallowSizeOf #399

merged 2 commits into from
Jun 19, 2020

Conversation

ordian
Copy link
Member

@ordian ordian commented Jun 15, 2020

This is useful for computing MallocSizeOf incrementally for a collection.

@ordian ordian mentioned this pull request Jun 15, 2020
Merged
@ordian ordian requested a review from cheme June 15, 2020 15:12
cheme
cheme approved these changes Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure about the test failure (rst-fmt ?).

@ordian ordian requested review from dvdplm and niklasad1 and removed request for dvdplm June 16, 2020 14:19
@niklasad1 niklasad1 merged commit cf53731 into master Jun 19, 2020
@niklasad1 niklasad1 deleted the ao-export-shallow-size-of branch June 19, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheme cheme cheme approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
A0-pleasereview A2-insubstantial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ordian @cheme @niklasad1