Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uint: Add checked_pow #417

Merged
merged 4 commits into from
Aug 3, 2020
Merged

uint: Add checked_pow #417

merged 4 commits into from
Aug 3, 2020

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Aug 2, 2020

Similar to how 025a0c1 added checked_{add,sub,mul,div,rem,neg} add
checked_pow.


Would prove useful for libp2p/rust-libp2p#1680.

Similar to how 025a0c1 added `checked_{add,sub,mul,div,rem,neg}` add
`checked_pow`.
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please add a line to the CHANGELOG, under `"unreleased".

uint/tests/uint_tests.rs Outdated Show resolved Hide resolved
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ordian
Copy link
Member

ordian commented Aug 3, 2020

(CI test failure is unrelated)

- Port `pow` and `pow_overflow` tests.

- Include overflow check in quickcheck suite.
@ordian ordian merged commit d3a2f9c into paritytech:master Aug 3, 2020
@mxinden
Copy link
Contributor Author

mxinden commented Aug 3, 2020

Thanks for the quick help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants