build(deps): update scale-info requirement from 0.5 to 0.6 #519
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [scale-info](https://github.com/paritytech/scale-info) to permit the latest version. - [Release notes](https://github.com/paritytech/scale-info/releases) - [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md) - [Commits](https://github.com/paritytech/scale-info/commits/v0.6.0) Signed-off-by: dependabot[bot] <support@github.com>
|
cc @ascjones any tips how to make it compile? |
Hm yes it does assume that there is a direct dependency on Maybe cases like this should make us reconsider. |
yeah, we generate codec impls via macro and don't depend on it directly, the compile error was super confusing as it worked fine with scale-info 0.5 |
primitive-types/Cargo.toml
Outdated
| @@ -14,7 +14,7 @@ impl-serde = { version = "0.3.1", path = "impls/serde", default-features = false | |||
| impl-codec = { version = "0.5.0", path = "impls/codec", default-features = false, optional = true } | |||
| impl-num-traits = { version = "0.1.0", path = "impls/num-traits", default-features = false, optional = true } | |||
| impl-rlp = { version = "0.3", path = "impls/rlp", default-features = false, optional = true } | |||
| scale-info = { version = "0.6", features = ["derive"], default-features = false, optional = true } | |||
| codec-info = { package = "scale-info", version = "0.6", features = ["derive"], default-features = false, optional = true } | |||
There was a problem hiding this comment.
Why rename it? To leave "scale-info" available as a feature name? If yes, how about scale-info-crate? It sucks too but at least it's clearer?
There was a problem hiding this comment.
Sure, will rename to scale-info-crate if that's clearer.
|
Updates the requirements on scale-info to permit the latest version.
Release notes
Sourced from scale-info's releases.
Changelog
Sourced from scale-info's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)