-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine scale-info
feature into codec
, and wire it through ethereum-types
#593
Combine scale-info
feature into codec
, and wire it through ethereum-types
#593
Conversation
This reminds me, now that we have
|
scale-info
feature to ethereum-types
scale-info
feature into codec
, and wire it through ethereum-types
Okay, this is ready for review. |
That would technically make this change breaking, because |
Currently, I've applied @ascjones suggestions to use 1.0 and combine it all into the codec feature. Shall I:
|
I would suggest reverting the changes for primitive-types and keeping everything else as is (modulo |
@ordian I believe I've done as you asked. Can you please review it again? |
Co-authored-by: Andronik Ordian <write@reusable.software>
Thanks for the review and merge everyone! I'd like this change to trickle down to frontier in time for Sub0 conference on October 14th if possible. What would it take to get a release of |
opened #594, will publish it soon |
@sorpaas @ascjones