Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uint: make max_value const, test, simplify #652

Merged
merged 5 commits into from
Aug 14, 2022

Conversation

webmaster128
Copy link
Contributor

@webmaster128 webmaster128 commented Jun 15, 2022

Based on #650 (merge this first)

@webmaster128 webmaster128 changed the title Make max_value const, test and simplify uint: Make max_value const, test and simplify Jun 15, 2022
@webmaster128 webmaster128 changed the title uint: Make max_value const, test and simplify uint: make max_value const, test and simplify Jun 15, 2022
@ordian
Copy link
Member

ordian commented Jun 15, 2022

We should probably deprecate max_value instead as it's deprecated in std: https://doc.rust-lang.org/std/primitive.u64.html#method.max_value.

@webmaster128 webmaster128 changed the title uint: make max_value const, test and simplify uint: make max_value const, test, simplify and deprecate Jun 15, 2022
@webmaster128
Copy link
Contributor Author

Right. Saw this too along the way. I deprecated it now.

uint/src/uint.rs Outdated Show resolved Hide resolved
Co-authored-by: Andronik <write@reusable.software>
@ordian ordian requested a review from niklasad1 June 15, 2022 12:03
uint/src/uint.rs Outdated Show resolved Hide resolved
uint/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Andronik <write@reusable.software>
@webmaster128 webmaster128 changed the title uint: make max_value const, test, simplify and deprecate uint: make max_value const, test, simplify Aug 14, 2022
@ordian ordian merged commit 6153693 into paritytech:master Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants