rocksdb: remove and simplify a bunch of stuff #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2022
ordian
force-pushed
the
ao-simplify-rocksdb
branch
from
a83871a
to
2e97d3d
Compare
Co-authored-by: cheme <emericchevalier.pro@gmail.com>
arkpar
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
KeyValueDB::restoreis removed. IIRC this was mainly used the parity-ethereum. I grepped usage in substrate and didn't find anyRwLockaround the inner db was needed for this method and now it's goneadd_columnandremove_last_columnnow require&mut selfowning_refis gone 馃帀Closes #659