Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic on bad size header #140

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Don't panic on bad size header #140

merged 2 commits into from
Oct 6, 2022

Conversation

arkpar
Copy link
Member

@arkpar arkpar commented Oct 5, 2022 •
edited
Loading

Proper error for #73

@arkpar arkpar requested review from Tpt and cheme October 5, 2022 19:59
@arkpar arkpar mentioned this pull request Oct 5, 2022
Closed
cheme
cheme approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with bound check, minor nit of the size in error message.

src/table.rs Outdated Show resolved Hide resolved
@arkpar @cheme
Error message
f293dfc 
Co-authored-by: cheme <emericchevalier.pro@gmail.com>
@arkpar arkpar merged commit ff3ef82 into master Oct 6, 2022
@arkpar arkpar deleted the a-bad-header branch October 6, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tpt Tpt Tpt approved these changes

@cheme cheme cheme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arkpar @Tpt @cheme