Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for adding new columns in existing db #144

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Support for adding new columns in existing db #144

merged 4 commits into from
Oct 12, 2022

Conversation

sandreim
Copy link
Contributor

@sandreim
More explicit error message
36ffe8e 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Add add_column and test
764e1ee 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix clippy
53d3aca 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
cheme
cheme reviewed Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just would add an additional check (see comment, I did not test it so might not compile)

src/db.rs Show resolved Hide resolved
arkpar
arkpar reviewed Oct 11, 2022
View reviewed changes
src/db.rs Outdated Show resolved Hide resolved
@sandreim
review feedback
f1ec904 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@arkpar arkpar merged commit 9df4c2f into master Oct 12, 2022
@arkpar arkpar deleted the sandreim/add_column branch October 12, 2022 15:10
@arkpar
Copy link
Member

arkpar commented Oct 12, 2022

Released in parity-db v0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheme cheme cheme approved these changes

@arkpar arkpar arkpar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support adding columns to existing DB
3 participants
@sandreim @arkpar @cheme