Uniform keys option for stress test. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
approved these changes
Feb 9, 2023
cheme
approved these changes
Feb 9, 2023
admin/src/bench/mod.rs
Outdated
Comment on lines
140
to
141
| for k in 0..num_keys { | ||
| let index = self.cache_start + k; |
There was a problem hiding this comment.
Suggested change
| for k in 0..num_keys { | |
| let index = self.cache_start + k; | |
| for index in self.cache_start..num_keys + k { |
| @@ -252,6 +294,19 @@ pub fn run_internal(args: Args, db: Db) { | |||
| 0 | |||
| }; | |||
|
|
|||
| let mut pool = SizePool::from_histogram(sizes::KUSAMA_STATE_DISTRIBUTION, args.uniform); | |||
| if args.uniform { | |||
| println!("Generating uniform keys."); | |||
There was a problem hiding this comment.
I am not too sure when we hit non cached keys, but good to have the code for it.
There was a problem hiding this comment.
Yeah. Reader threads when appending will hit them. Also, writer threads when pruning and appending can hit them sometimes. Might have missed something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the hash function when generating keys and uses a uniform column. It also generates the keys before running the rest of the stress test so the hash function isn't used during the test. I found this useful for profiling.
Caveats
Uses memory to store all the keys.
When appending to a database it only generates keys for the current run. Reader threads can read from the whole database so will sometimes end up executing the hash function during the test.