Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Constantinople Release #8427

Closed
5 of 6 tasks
5chdn opened this issue Apr 18, 2018 · 3 comments
Closed
5 of 6 tasks

Constantinople Release #8427

5chdn opened this issue Apr 18, 2018 · 3 comments
Labels
B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. Q7-involved 💪 Can be fixed by a team of developers and probably takes some time.
Milestone

Comments

@5chdn
Copy link
Contributor

5chdn commented Apr 18, 2018

Tracking issue for Constantinople EIPs implementation progress:

Hardfork Meta EIP:

Timeline:

Proposed Constantinople Timeline
Finalize EIPs that are being implemented: July 13th
Client implementation: July 16th - August 13th
Testing: August 13th - September 10th
Testnet: September 10th - October 1st
Launch: October 8th

@5chdn 5chdn added P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. Q7-involved 💪 Can be fixed by a team of developers and probably takes some time. M4-core ⛓ Core client code / Rust. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. labels Apr 18, 2018
@5chdn 5chdn added this to the 1.12 milestone Apr 18, 2018
@5chdn 5chdn modified the milestones: 1.12, 1.13 Apr 24, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Jul 17, 2018
@5chdn 5chdn added this to the 2.1 milestone Jul 27, 2018
@folsen
Copy link
Contributor

folsen commented Jul 27, 2018

Geth implementation of 1087 ethereum/go-ethereum#17208

@5chdn 5chdn added the B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. label Jul 27, 2018
@sorpaas
Copy link
Collaborator

sorpaas commented Jul 30, 2018

I'm having some issues getting EIP-1087 implemented in our codebase. With our current state cache method, we can do it, but with (probably noticeable) performance penalty. The issue is that we optimize state commitment to only happen at the end of a block, but EIP-1087 makes the assumption that state commitment happens at the end of every transaction.

So to implement current spec, it seems that we cannot use info from current cache (because storage caches, including checkpoints, also contain changes from previous transactions), but instead, we need to maintain a separate dirty map just to keep track of the gas cost. That dirty map will probably also need to contain the original storage value. So adding up, in this way, it basically doubles the memory size of storage cache.

Edit: trying to draft an alternative of EIP-1087 that may solve this problem. One possible limitation of this is that it doesn't deal with nested call frame, but it looks to be sufficient for all examples provided in EIP-1087 (reentry lock, multiple increments, multi-send). ethereum/EIPs#1283

@5chdn
Copy link
Contributor Author

5chdn commented Sep 8, 2018

All done. Can start testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. Q7-involved 💪 Can be fixed by a team of developers and probably takes some time.
Projects
None yet
Development

No branches or pull requests

3 participants