Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

misc: bump license header to 2019 #10135

Merged
merged 5 commits into from
Jan 7, 2019
Merged

misc: bump license header to 2019 #10135

merged 5 commits into from
Jan 7, 2019

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Jan 4, 2019

I'm sorry 😆

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M3-docs 📑 Documentation. labels Jan 4, 2019
@5chdn 5chdn added this to the 2.3 milestone Jan 4, 2019
@sorpaas sorpaas removed the A0-pleasereview 🤓 Pull request needs code review. label Jan 4, 2019
@sorpaas
Copy link
Collaborator

sorpaas commented Jan 4, 2019

I think the Cargo.lock issue is not caused by this PR. It should be able to be fixed by running cargo locally once.

@sorpaas sorpaas added the A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. label Jan 4, 2019
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Jan 4, 2019
@rphmeier
Copy link
Contributor

rphmeier commented Jan 4, 2019 •
edited
Loading

Is this actually something you're supposed to do if the files haven't been changed in 2019?

@rphmeier rphmeier added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jan 4, 2019
@5chdn
Copy link
Contributor Author

5chdn commented Jan 5, 2019

We are doing this every year so developers can focus on code. #8666

And technically, these files just changed ;-)

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jan 5, 2019
@5chdn 5chdn merged commit 7c335e8 into master Jan 7, 2019
@5chdn 5chdn deleted the a5-happy-2019 branch January 7, 2019 10:33
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorpaas sorpaas sorpaas approved these changes

@mattrutherford mattrutherford mattrutherford approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M3-docs 📑 Documentation.
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@5chdn @sorpaas @rphmeier @mattrutherford