This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
pull constantinople on ethereum network #10189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
5chdn
commented
Jan 15, 2019
•
5chdn
commented
- ethcore: pull constantinople on ethereum network
- version: revert fork block for ethereum
- version: mark update as critical on kovan (Update pwasm-utils to 0.6.1 #10134) and ethereum networks (pull constantinople on ethereum network #10189)
5chdn
added
A0-pleasereview 🤓
jam10o-new
approved these changes
Jan 15, 2019
andresilva
suggested changes
Jan 15, 2019
util/version/Cargo.toml
Outdated
| @@ -16,9 +16,9 @@ track = "nightly" | |||
| # Latest supported fork blocks. | |||
| # Indicates a critical release in this track (i.e. consensus issue). | |||
| [package.metadata.networks] | |||
| foundation = { forkBlock = 7080000, critical = false } | |||
| foundation = { forkBlock = 7080000, critical = true } | |||
There was a problem hiding this comment.
Shouldn't we revert the forkBlock as well to 4370000?
andresilva
reviewed
Jan 15, 2019
andresilva
approved these changes
Jan 15, 2019
kirushik
approved these changes
Jan 15, 2019
5chdn
added a commit
that referenced
this pull request
Jan 15, 2019
* ethcore: pull constantinople on ethereum network * version: mark update as critical * ethcore: remove constantinople alltogether from chain spec * version: revert fork block for ethereum
5chdn
added a commit
that referenced
this pull request
Jan 15, 2019
* ethcore: pull constantinople on ethereum network * version: mark update as critical * ethcore: remove constantinople alltogether from chain spec * version: revert fork block for ethereum
This was referenced Jan 15, 2019
5chdn
added a commit
that referenced
this pull request
Jan 15, 2019
* version: bump stable to 2.2.7 * version: mark 2.2 track stable * version: mark update critical on all networks * version: commit cargo lock * Ping nodes from discovery (#10167) * snap: fix path in script (#10157) * snap: fix path in script * debug, revert me * fix * necromancer awk magic * awk necromancy and path fixing * working track selection * Fix _cannot recursively call into `Core`_ issue (#10144) * Change igd to github:maufl/rust-igd * Run `igd::search_gateway_from_timeout` from own thread * Handle the case for contract creation on an empty but exist account with storage items (#10065) * Add is_base_storage_root_unchanged * Fix compile, use a shortcut for check, and remove ignored tests * Add a warn! * Update ethereum/tests to v6.0.0-beta.2 * grumble: use {:#x} instead of 0x{:x} Co-Authored-By: sorpaas <accounts@that.world> * version: bump fork blocks for kovan and foundation (#10186) * pull constantinople on ethereum network (#10189) * ethcore: pull constantinople on ethereum network * version: mark update as critical * ethcore: remove constantinople alltogether from chain spec * version: revert fork block for ethereum
5chdn
added a commit
that referenced
this pull request
Jan 15, 2019
* version: mark 2.3 track beta * version: mark update critical on all networks * Ping nodes from discovery (#10167) * Fix _cannot recursively call into `Core`_ issue (#10144) * Change igd to github:maufl/rust-igd * Run `igd::search_gateway_from_timeout` from own thread * Handle the case for contract creation on an empty but exist account with storage items (#10065) * Add is_base_storage_root_unchanged * Fix compile, use a shortcut for check, and remove ignored tests * Add a warn! * Update ethereum/tests to v6.0.0-beta.2 * grumble: use {:#x} instead of 0x{:x} Co-Authored-By: sorpaas <accounts@that.world> * version: bump fork blocks for kovan and foundation (#10186) * pull constantinople on ethereum network (#10189) * ethcore: pull constantinople on ethereum network * version: mark update as critical * ethcore: remove constantinople alltogether from chain spec * version: revert fork block for ethereum
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.