Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

rename is_pruned to is_prunable #10888

Merged
merged 1 commit into from
Jul 16, 2019
Merged

rename is_pruned to is_prunable #10888

merged 1 commit into from
Jul 16, 2019

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 15, 2019

I find function name is_pruned to be confusing in several cases

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 15, 2019
ordian
ordian approved these changes Jul 16, 2019
View reviewed changes
Copy link
Collaborator

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@ordian ordian added this to the 2.7 milestone Jul 16, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 16, 2019
@sorpaas sorpaas merged commit 27d1c2d into master Jul 16, 2019
@sorpaas sorpaas deleted the prunable branch July 16, 2019 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@sorpaas sorpaas sorpaas approved these changes

@dvdplm dvdplm Awaiting requested review from dvdplm

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @ordian @sorpaas