This repository has been archived by the owner on Mar 25, 2019. It is now read-only.
Configure the Secure API for embed Signer #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
suggested changes
Mar 15, 2017
web3/index.js
Outdated
| const dappsPort = DAPPS.split(':')[1]; | ||
|
|
||
| if (dappsInterface) { | ||
| window.secureApi._dappsInterface = dappsInterface; |
There was a problem hiding this comment.
A bit hacky to modify private fields. Can we expose this as a method in new versions of Parity?
There was a problem hiding this comment.
Yes, it is hacky :/ Would be better to expose those from the API, but this means that users must update to a new version of the UI. Will implement it though
There was a problem hiding this comment.
Yeah. Let's use proper public method for new versions and that hack for old ones (i.e. if the method is not available)
There was a problem hiding this comment.
Updated (needs openethereum/parity-ethereum#4922)
tomusdrw
approved these changes
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/ethcore/parity/issues/4885