Support constant expressions as index attribute variant #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the capability to use constant expressions as index attribute variants for enum encoding, addressing the demand from issue paritytech/polkadot-sdk#2665. This update allows developers to declare pallet indices as constants when constructing a runtime.
The uniqueness of constant expression indices is ensured at compile time with
find_const_duplicate. Due to limitations in Rust's procedural macros, a runtime check approach is adopted to ensure that indices adhere to the u8 range. UI tests have been included to cover various scenarios, ensuring that the checks function as expected.