This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Replace Vec with Box in br table #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Should kinda ease the #135 issue. I'm wondering is it feasible to add a test so we don't regress in size of |
pepyakin
approved these changes
Jan 22, 2018
sunfishcode
added a commit
to sunfishcode/wasmparser.rs
that referenced
this pull request
Jan 22, 2018
Boxed slices aren't resizable, so they don't contain a capacity field, so they're smaller than Vecs. Inspired by paritytech/parity-wasm#154.
sunfishcode
added a commit
to sunfishcode/wasmparser.rs
that referenced
this pull request
Jan 22, 2018
Boxed slices aren't resizable, so they don't contain a capacity field, so they're smaller than Vecs. This change shrinks ParserState from 64 bytes to 56 bytes (on x64). Inspired by paritytech/parity-wasm#154.
sunfishcode
added a commit
to sunfishcode/wasmparser.rs
that referenced
this pull request
Sep 27, 2018
Boxed slices aren't resizable, so they don't contain a capacity field, so they're smaller than Vecs. This change shrinks ParserState from 64 bytes to 56 bytes (on x64). Inspired by paritytech/parity-wasm#154.
sunfishcode
added a commit
to sunfishcode/wasmparser.rs
that referenced
this pull request
Sep 28, 2018
Boxed slices aren't resizable, so they don't contain a capacity field, so they're smaller than Vecs. This change shrinks ParserState from 64 bytes to 56 bytes (on x64). Inspired by paritytech/parity-wasm#154.
yurydelendik
pushed a commit
to sunfishcode/wasmparser.rs
that referenced
this pull request
Sep 28, 2018
Boxed slices aren't resizable, so they don't contain a capacity field, so they're smaller than Vecs. This change shrinks ParserState from 64 bytes to 56 bytes (on x64). Inspired by paritytech/parity-wasm#154.
yurydelendik
pushed a commit
to bytecodealliance/wasmparser
that referenced
this pull request
Sep 28, 2018
Boxed slices aren't resizable, so they don't contain a capacity field, so they're smaller than Vecs. This change shrinks ParserState from 64 bytes to 56 bytes (on x64). Inspired by paritytech/parity-wasm#154.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should reduce size of each opcode by usize